Series archive and index URLs don't match

Neurotic Forums » Neurotic Plugins » Organize Series WordPress Plugin » Usage Help

Series archive and index URLs don't match

(27 posts) (3 voices)

Started 11 months ago by fhsm
Latest reply from Darren
This topic is resolved

Tags:

fhsm
Member

My site's permalink structure is /archive/%postname%.html. I have the series plugin index link set to /series/. This is causing me two problems.

First my other parges and archive views do not include a trailing slash. I've tried to set the series index to /series however on saving it looks like the code is 'correcting' this to /series/. It seems like I should be able to include or not include the trailing slash. What am I missing?

Second when I view a particular series archive (not the series index page showing all my various series but instead the page showing all the posts that make up a single particular series) the URL is /archive/series/series-name. How can I keep /archive from getting introduced into the URL? I'd like it to just be /series/series-name.

Thanks for a great plugin.

Posted 11 months ago #
Darren
Neurotic Guy

I don't have time atm to look at the adding of the trailing slash - if I get a chance this week I'll take a gander.

I have a question about /archive/series/series-name however. What is the URL for calling a category page? Is it /archive/category/category-name? "Series" is a new taxonomy and works with the built-in permalinks for WordPress. It follows whatever you set for the permalink structure. Make sense?

Posted 11 months ago #
fhsm
Member

Thanks for the quick reply. It's amazing that you take the time to answer all these questions. I look forward to your thoughts on the trailing slash.

I have "topic" as my category base so it is /topic/category-name if I delete topic in the admin it defaults back to /category/category-name (tags are /tag/tag-name). The combination of having the series index at /series and getting to categories at /category/category-name but having an actual series preceded by /archive was surprising.

I'm running 2.8.4 just in case that has anything to do with it.

Posted 11 months ago #
Darren
Neurotic Guy

Let me repeat back what I'm understanding from what you wrote so I make sure I'm clear on what's happening.

1. Your category permalinks are setup as /topic/category-name.
2. Your sites permalink structure for posts is /archive/%postname%.html (which means all post pages have that structure.
3. Series archive pages are showing up as /archive/series/series-name.
4. You'd like it so Series archive pages are just showing /series/series-name.

This is a new one for me. When I get a chance I'll test. I have a niggling thought as to what may be causing this - I'll get back to you on what I find.

Posted 10 months ago #
fhsm
Member

All of that is correct. I wish I could point you to a live site but right now I'm just building locally. The only possibility significant detail I would add is:

3.5. The page that lists all the different series I have created appears at /series (not at /archive/series).

Thanks for the help.

Posted 10 months ago #
fhsm
Member

I've tried fooling around with the permalink structure a bit more and noticed that the temporal archive is also perpended with /archive (ex: /archive/2008/11, instead of just /2008/11).

I'd never noticed this because I'm try to deemphasize publication date but thought I'd add this to the mix.

So what are you thinking could be going on here?

Posted 10 months ago #
Darren
Neurotic Guy

If you disable Organize Series does the temporal archive still have "/archive/2008/11"? If so, then at least you've eliminated Organize Series as being the culprit (I'm beginning to suspect it isn't). In which case you'll want to see if there are any other plugins that affect your permalink structure.

Posted 10 months ago #
fhsm
Member

If I disable every plugin the temporal archive is still "archive/2008/11" to make that go away I need to remove the word archive from the permalinks page. This takes the word archive out of a post permalink urls, the organize series urls and out of the temporal archive.

I don't mind having archive show up in front of the dates both because I don't use the date based links at all and even if I did I could convince myself that it is logical. I don't think this is a case of Organize Series 'breaking' the rest of the site, it's a case of OS not being at the URL I would expect / like it to be at.

I'm trying to have series behave like tags and categories with respect to URLs so I get the series archive pages at /series/series-name instead of /archive/series/series-name in the same way that I have /topic/category-name not /archive/topic/catagory-name.

Posted 10 months ago #
Darren
Neurotic Guy

I *may* look into modifying the permalink structure of series archive pages but it is definitely not something in the "must do" category. Sorry.

Posted 10 months ago #
fhsm
Member

Could you point me to the part of the your code where the URL magic happens?

Posted 10 months ago #
Darren
Neurotic Guy

all the permalink stuff is in the series-utility.php file

Posted 10 months ago #
fhsm
Member

Thanks.

Another observation: if I change the Series Table of Contents URL on the plugin settings page to something other than series say 'testing' the TOC is now at /testing; however, the series stay at /archive/series/series-name.

As I've looked around I guess this isn't a surprise given the code; however, I'm not sure if it is the behavior one would expect. It seems like the TOC page slug and the series URI segment should be the same, the description on the settings page should be more explicit about what will change, or two settings should be provided.

Posted 10 months ago #

fhsm
Member

I had a look in series-utility.php and it seems like adding 'archive' or _whatever_ was a design decision on your part, not a side effect. Is that the case?

On lines 109 and 396 you include $wp_rewrite->front, $front is 'archive' in my case, if I go back to a standard permalink structure (ex: /%year%/%monthnum%/%postname%/) then $front is empty.

So I'm wondering if all it takes to make the plugin do what I'd like it to do is drop the $wp_rewrite->front and replace it with a /. Patch:

--- series-utility.php	        2009-10-19 10:59:48.000000000 -0400
+++ new-series-utility.php	2009-10-19 11:01:39.000000000 -0400
@@ -106,7 +106,8 @@
 	$wp_rewrite->add_rewrite_tag($series_token, '(.+)', SERIES_QUERYVAR . '=');
    	//without trailing slash
-	$series_structure = $wp_rewrite->front . SERIES_URL . "/$series_token";
+//	$series_structure = $wp_rewrite->front . SERIES_URL . "/$series_token";
+	$series_strucutre = '/' . SERIES_URL . "/$series_token";
 	$rewrite = $wp_rewrite->generate_rewrite_rules($series_structure);
 	return ( $rewrite + $rules );
@@ -393,7 +394,8 @@
 	}
 	$series_token = '%' . SERIES_QUERYVAR . '%';
-	$series_structure = $wp_rewrite->front . SERIES_URL . "/$series_token";
+//	$series_structure = $wp_rewrite->front . SERIES_URL . "/$series_token";
+	$series_structure = '/' . SERIES_URL . "/$series_token";
 	return $series_structure;
 }

Here's a link to a nicer version of the patch: http://snipt.org/oul

And the function reference on $front: http://codex.wordpress.org/index.php?title=Function_Reference/WP_Rewrite

I really have no idea how your plugin works so any input you can provide on this patch would be much appreciated.

Posted 10 months ago #

bentforkz
Member

I just updated to the new OrgSeries plugin.

I believe there is an issue, bug or re-write of the TOC "Series Table of Contents URL" option.

In the previous version of OrgSeries, if a user entered a TOC URL, that URL was part of the series url.

For example, if I entered "/spotlights" as the TOC url, all of the posts within the series "academics" would have been found at "/spotlights/academics"

Now it seems the TOC URL reverts to be /"series/academics" instead of the URL I entered.

Thoughts?

Posted 10 months ago #
Darren
Neurotic Guy

fhsm,
I'll take a look at what you are suggesting and see if it's something that can be addressed. Offhand however the $wp_rewrite->front includes all the "front" address for the permalink (i.e. the http://myblogaddress.com... part). So just replacing it with a "/" won't do the trick I think. I'll see.

bentforkz,
The TOC url is meant to be where the series table of contents for ALL series is located. I don't currently (and never did) have an option for changing the series permalink tag via the series options page but there is a place where you can change it in the orgSeries.php file (line 83). Careful with this though...I think in the latest version there may be some places where I hardcoded "series" rather than calling the SERIES_URL definition.

Posted 10 months ago #
fhsm
Member

Unless I'm missing something it looks like $front just holds a non-variable part of of the URL between the site root URL (example.com/) and the variable permalink structure (%postname%, etc).

If I echo $front it just contains 'archive', nothing more. It looks like $root would contain the site base URL. I've done a little echo testing and found that with $front my URLs are localhost/archive/series/%series-name%, without the '/' or $front links are written as localhostseries/%series-name%, with the slash I get the desired localhost/series/%series-name%.

This is not just the browser interpreting a relative URL. The actual source shows links hard coded to http://localhost/series/%series-name%. That said if I echo out the structure it does not include the domain (localhost / example.com whatever), of course it doesn't include that if I echo out the original unmodified code either.

I've tested the patch enough to say that applying it does not obviously break display and does get the URLs to do what I'd like them to do. I'll be interested to hear what you find when you have a look at it.

==edit==
The comments around $front & $root in wp-includes/rewrite.php starting on line 482 are somewhat more helpful than the codex. It looks like the patch I posted could toast a site that wasn't using fancy permalinks or moving the front controller around.

Posted 10 months ago #
Darren
Neurotic Guy

The new release of Organize Series (2.1.5) has a new feature where you can designate a "custom base" on the Series Options page. This will take care of all the stuff you are talking about here. Let me know how it works!

Posted 10 months ago #
fhsm
Member

This seems to let me get done what I was originally after, with the following settings:

Series Table of Contents URL: series/
Series Custom Base: /series

Thanks for the update.

Posted 10 months ago #
fhsm
Member

Maybe I spoke too soon on this. I've noticed another small inconsistency in my permalinks. I don't use a trailing slash on my pages or categories and tags archives. For example my about page is just /about, not /about/ and the archive for a category is at /topic/category-name, not /topic/category-name/.

I can't seem to get the series table of contents to follow this pattern. If I use just 'series' when I save the options it is changed to 'series/.' Visiting /series will get me to the TOC with a redirect to /series/, but I'd like /series to be canonical.

I've been able to work around this by making a change directly in the database; however, that's not really a great long term solution. Any chance the trailing slash could be optional in version 2.1.6?

Posted 10 months ago #
Darren
Neurotic Guy

Yup, I can do that and it's done in trunk now. I'm probably not going to release 2.1.6 right away though. I want to wait and see if there are any other bugs to fix with this release yet first. So I'll give it the weekend and see what happens.

Posted 10 months ago #
fhsm
Member

Thanks for the help / responsive maintenance of your plugin.

Posted 10 months ago #
fhsm
Member

Did the upgrade and dropped the trailing slash of my ToC option field, the option saved as 'series' without any problem; however, the ToC is still showing up at /series/ even though the option is /series.

Any ideas?

Posted 9 months ago #
Darren
Neurotic Guy

I just did a test. When I drop the trailing slash I can access the series toc at /seriestoc OR /seriestoc/ I believe that is the way the core WordPress is set up to deal with making sure all links are canonical in resolving either way.

I'm not sure what the problem is here?

Posted 9 months ago #
fhsm
Member

I can get to it either way as well; however, /series redirects to /series/ and I want /series, not /series/ to be the canonical URL.

Posted 9 months ago #
Darren
Neurotic Guy

This is what I'm trying to reproduce but can't. However, I'm not using /series as the seriestoc url tag because the way my permalinks are setup I can't have it the same as the default "/series" So, I'm wondering, if something related to that is happening with you. Can you try using a url other than "series" for your seriestoc and see if you still get the problem?

Posted 9 months ago #
fhsm
Member

I get the same behavior regardless of what I use for the TOC stub. Not sure what the problem is. I thought it could be another plugin but I turned everything else off and I still get the same redirect to /whatever/.

Any suggestions on what I could do to trouble shoot this?

Posted 9 months ago #
Darren
Neurotic Guy

I'm out of ideas unless it's something specific to the theme you are using. You could try a different theme and see if you get the same problem.

Posted 9 months ago #

RSS feed for this topic

Reply

You must log in to post.